The negative attention has delayed this though as it's affected the maintainer and could have been handled better considering the actual impact was overblown. Just so that you're aware, the PR is going to be reviewed at a later date and more than likely merged.
Actix for production code#
It wouldn't impact any actual users of the project, the only way that it could is if the maintainer added/merged code that'd introduce the UB. I don't think that was considered by the maintainer, and thus they felt the value of the PR was questionable(as they only thought about their own perspective as the project maintainer?). The PR did have value to any potential contributors, or future reviewers/maintainers. kind of like many other crates which might use unsafe internally(even Vec does?), which would require code review to pickup on introducing UBs? The PR was for internal code, only contributors to the project could introduce UB from it, which the maintainer is adamant they'd pickup during code review. There wasn't any assessment on perf impact was there? It's just assumed?
Actix for production Patch#
Just my anecdotal 2c.ĭismissiveness that was shown to a perf-neutral PR whose only goal was to patch unsoundness holes caused by overuse of unsafe throughout the codebase concerns me. I must say, /u/fafhrd91 was very helpful identifying where the issue was and getting my PR merged. This wasn't just my first PR to a rust project, but my first PR to the OSS ecosystem in general. After a couple of commits, /u/fafhrd91 merged the PR and made a release shortly after. After discussing the issue with /u/fafhrd91 on gitter, he was able to point me to where in the code things would need changed and also provide suggestions on the best way to expose the API publicly. Setting the max size of payloads for WebSockets wasn't exposed by the public API. I've recently had a very pleasant experience getting a PR accepted into actix-web.
Actix for production software#
Also some of our software is moving into the embedded space and running Scala web frameworks on things like a Pi doesn't play very well. I've been porting one of our production apps from Scala/Akka to Actix for performance benefits and a smaller memory footprint. I'm fairly new to the rust community and come from a heavy JVM based ecosystem. We'll do our best to keep these links up to date, but if we fall behind please don't hesitate to shoot us a modmail. This is not an official Rust forum, and cannot fulfill feature requests. Err on the side of giving others the benefit of the doubt.Īvoid re-treading topics that have been long-settled or utterly exhausted. Please create a read-only mirror and link that instead.Ī programming language is rarely worth getting worked up over.īe charitable in intent. If criticizing a project on GitHub, you may not link directly to the project's issue tracker. Post titles should include useful context.įor Rust questions, use the stickied Q&A thread.Īrts-and-crafts posts are permitted on weekends.Ĭriticism is encouraged, though it must be constructive, useful and actionable. For content that does not, use a text post to explain its relevance. Posts must reference Rust or relate to things using Rust. We observe the Rust Project Code of Conduct. Strive to treat others with respect, patience, kindness, and empathy. Please read The Rust Community Code of Conduct The Rust Programming LanguageĪ place for all things related to the Rust programming language-an open-source systems language that emphasizes performance, reliability, and productivity.
0 kommentar(er)
